Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-truncate-text): fix TruncateText not working inside TopNavBar.Item #1311

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

balzss
Copy link
Contributor

@balzss balzss commented Oct 10, 2023

INSTUI-3883

context: the issue was caused by <TopNavBar.Item> setting it's style to whiteSpace: 'nowrap' which needs to be overridden in TruncateText

test plan:

  • check the example from the jira issue, the text should be truncated:
<TopNavBar.Item>
  <div style={{width: '5rem', display:"inline-block"}}>
    <TruncateText>
    Long text that should be truncated, but it's really not truncated
    </TruncateText>
  </div>
</TopNavBar.Item>

@balzss balzss requested review from HerrTopi and joyenjoyer October 10, 2023 13:28
@github-actions
Copy link

Preview URL: https://1311--preview-instui.netlify.app

@balzss balzss self-assigned this Oct 10, 2023
@balzss balzss requested a review from matyasf October 11, 2023 13:09
@HerrTopi HerrTopi removed the request for review from joyenjoyer October 11, 2023 13:09
@balzss balzss merged commit 5253173 into master Oct 11, 2023
4 checks passed
@balzss balzss deleted the fix/truncate-whitespace-style branch October 11, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants