Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ui-checkbox): migrate old Checkbox tests #1312

Merged
merged 1 commit into from
Oct 16, 2023
Merged

test(ui-checkbox): migrate old Checkbox tests #1312

merged 1 commit into from
Oct 16, 2023

Conversation

git-nandor
Copy link
Contributor

Closes: INSTUI-3878

@github-actions
Copy link

Preview URL: https://1312--preview-instui.netlify.app

@git-nandor git-nandor marked this pull request as ready for review October 11, 2023 08:37
@git-nandor git-nandor self-assigned this Oct 11, 2023
@git-nandor git-nandor force-pushed the INSTUI-3878_convert_ui-checkbox_to_the_new_test_format branch from f2a9b6e to 034aaf7 Compare October 12, 2023 10:23
@joyenjoyer
Copy link
Contributor

I accepted the diff in the UI tests. It was just some minor pixel smoothing.

@git-nandor git-nandor force-pushed the INSTUI-3878_convert_ui-checkbox_to_the_new_test_format branch from 034aaf7 to 8e1ffb2 Compare October 16, 2023 08:46
@balzss balzss merged commit 065d3e7 into master Oct 16, 2023
4 checks passed
@balzss balzss deleted the INSTUI-3878_convert_ui-checkbox_to_the_new_test_format branch October 16, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyenjoyer joyenjoyer joyenjoyer approved these changes

@balzss balzss balzss approved these changes

Assignees

@git-nandor git-nandor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@git-nandor @joyenjoyer @balzss