feat(ui-tabs): add active property to tabs #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL: https://1327--preview-instui.netlify.app |
joyenjoyer
force-pushed
the
INSTUI-3876_tabs_react_router
branch
from
5d43dfb to
05f8708
Compare
matyasf
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Looks good. While I'm not a fan of this new API (its confusing, e.g. why am I able to specify children to all tabs when 1 will be rendered anyway?) I guess we cant do more without breaking changes. In the future we should switch to a similar structure as material-ui IMO https://mui.com/material-ui/react-tabs/#experimental-api
joyenjoyer
force-pushed
the
INSTUI-3876_tabs_react_router
branch
2 times, most recently
from
77cee34 to
3c4e72f
Compare
balzss
approved these changes
Oct 20, 2023
joyenjoyer
force-pushed
the
INSTUI-3876_tabs_react_router
branch
2 times, most recently
from
4144e40 to
6d2e2f6
Compare
Closes: INSTUI-3876 Add support for multiple tabs->one tab panel. This makes using React Router easier with less boilerplate code.
joyenjoyer
force-pushed
the
INSTUI-3876_tabs_react_router
branch
from
6d2e2f6 to
5389732
Compare
joyenjoyer
commented
Oct 23, 2023
| expect(childContent).toBeNull() | ||
| }) | ||
|
|
||
| it('should render the same content in second tab when selected', () => { |
There was a problem hiding this comment.
I added a test as you requested. @matyasf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: INSTUI-3876
Add support for multiple tabs->one tab panel. This makes using React Router easier with less boilerplate code.
Test plan: check if the new example in the Tabs page works fine.