Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inst UI 3879 convert UI dialog to the new test format #1328

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Inst UI 3879 convert UI dialog to the new test format #1328

merged 1 commit into from
Oct 24, 2023

Conversation

git-nandor
Copy link
Contributor

No description provided.

@git-nandor git-nandor self-assigned this Oct 18, 2023
@git-nandor git-nandor force-pushed the INSTUI-3879_convert_ui-dialog_to_the_new_test_format branch 2 times, most recently from b7ffa47 to 17f4c09 Compare October 18, 2023 15:24
@git-nandor git-nandor marked this pull request as ready for review October 18, 2023 15:25
@git-nandor git-nandor force-pushed the INSTUI-3879_convert_ui-dialog_to_the_new_test_format branch from 17f4c09 to 520b400 Compare October 18, 2023 15:43
@github-actions
Copy link

Preview URL: https://1328--preview-instui.netlify.app

balzss
balzss requested changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@balzss balzss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the latest versions of the testing library packages. you can do this by deleting the related lines from the package.json and install them with npm i -D @testing-library/jest-dom @testing-library/react @testing-library/user-event

@git-nandor git-nandor force-pushed the INSTUI-3879_convert_ui-dialog_to_the_new_test_format branch 4 times, most recently from 220ee6b to cc1cf9b Compare October 19, 2023 12:18
@git-nandor git-nandor requested a review from balzss October 19, 2023 12:21
@git-nandor git-nandor force-pushed the INSTUI-3879_convert_ui-dialog_to_the_new_test_format branch from cc1cf9b to 507085f Compare October 24, 2023 07:27
@git-nandor git-nandor merged commit 02f2c7f into master Oct 24, 2023
4 checks passed
@git-nandor git-nandor deleted the INSTUI-3879_convert_ui-dialog_to_the_new_test_format branch October 24, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyenjoyer joyenjoyer joyenjoyer approved these changes

@balzss balzss balzss approved these changes

Assignees

@git-nandor git-nandor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@git-nandor @balzss @joyenjoyer