Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support ReactTestUtils in decorators that use forwardRef #1329

Merged
merged 1 commit into from
Oct 26, 2023
Merged

support ReactTestUtils in decorators that use forwardRef #1329

merged 1 commit into from
Oct 26, 2023

Conversation

balzss
Copy link
Contributor

@balzss balzss commented Oct 18, 2023

INSTUI-3893

@balzss balzss self-assigned this Oct 18, 2023
@github-actions
Copy link

Preview URL: https://1329--preview-instui.netlify.app

@balzss balzss force-pushed the fix/emotion-forwardref branch 2 times, most recently from 7fc71f5 to e822226 Compare October 25, 2023 10:38
@balzss balzss requested review from matyasf and joyenjoyer October 25, 2023 10:40
@balzss balzss changed the title fix(emotion): support ReactTestUtils in decorators that use forwardRef support ReactTestUtils in decorators that use forwardRef Oct 25, 2023
matyasf
matyasf requested changes Oct 25, 2023
View reviewed changes
packages/emotion/src/__tests__/withStyle.test.tsx Outdated
}
}

it.only('can be found and tested with ReactTestUtils', async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove .only

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

packages/emotion/src/__tests__/withStyle.test.tsx Show resolved Hide resolved
joyenjoyer
joyenjoyer approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@joyenjoyer joyenjoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@balzss balzss force-pushed the fix/emotion-forwardref branch from e822226 to 0d05f7d Compare October 25, 2023 15:11
@balzss balzss requested a review from matyasf October 25, 2023 15:12
@balzss balzss merged commit 3568250 into master Oct 26, 2023
4 checks passed
@balzss balzss deleted the fix/emotion-forwardref branch October 26, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyenjoyer joyenjoyer joyenjoyer approved these changes

@matyasf matyasf matyasf approved these changes

Assignees

@balzss balzss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balzss @matyasf @joyenjoyer