INSTUI-3890 simplify Docs build pipeline #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@tsProps was used when the codebase was mixed JS and TS, now its not nededed since its pure TS
refresh react-dogen types remove unused jsdoc parser code
|
Preview URL: https://1330--preview-instui.netlify.app |
matyasf
commented
Oct 20, 2023
| @@ -85,77 +92,61 @@ type JSDocFunctionReturns = { | |||
| names: string[] | |||
| } | |||
| } | |||
| // TODO remove these types, now we can get them directly from react-docgen | |||
| // TODO these are from React-docgen Documentation.d.ts, | |||
| // remove when react-docgen exports them | |||
There was a problem hiding this comment.
I've opened a ticket for them reactjs/react-docgen#864
There was a problem hiding this comment.
this code is just a refresh (copypaste) of their type definitions
matyasf
commented
Oct 20, 2023
| @@ -55,18 +56,6 @@ export function getJSDoc(source: Buffer, error: (err: Error) => void) { | |||
| } | |||
| doc = { | |||
| ...module, | |||
| sections: sections | |||
There was a problem hiding this comment.
this part was never used by the docs
matyasf
commented
Oct 20, 2023
| @@ -368,31 +361,6 @@ import { ${importName} } from '${esPath}' | |||
| ) | |||
| } | |||
|
|
|||
| let sections | |||
|
|
|||
| if (doc.sections) { | |||
There was a problem hiding this comment.
this was always empty
matyasf
changed the title
HerrTopi
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make typings better, remove some dead code.
TEST PLAN:
Compare the docs pages (especially the props part) with the current prod one and check if nothing is missing/changed