Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui-top-nav-bar): add as property to TopNavBarItem #1331

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

joyenjoyer
Copy link
Contributor

Closes: INSTUI-3910

@joyenjoyer joyenjoyer self-assigned this Oct 25, 2023
@joyenjoyer joyenjoyer requested review from balzss and HerrTopi October 25, 2023 13:23
@@ -1436,6 +1436,22 @@ describe('<TopNavBarItem />', async () => {
})
})

describe('as prop', async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be moved to new tests by Nandi.

@github-actions
Copy link

Preview URL: https://1331--preview-instui.netlify.app

@joyenjoyer joyenjoyer requested a review from matyasf October 26, 2023 08:41
@joyenjoyer joyenjoyer merged commit d471c16 into master Oct 27, 2023
4 checks passed
@joyenjoyer joyenjoyer deleted the INSTUI-3910_topnavbar-button-a branch October 27, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants