fix(ui-a11y-utils): handleDocumentClick should only capture mouse events #1332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTUI-3907
explanation: for
shouldCloseOnDocumentClick
we used to have two mousedown listeners: one for capturing the document click (store the target) and one for handling it (close document if target is outside the context, e.g. modal). the latter were converted to a click listener to fix the order of execution but that introduced this bug because the click listener can also capture events like pressing space on a checkbox (for a11y reasons). the solution is to use a mouseup listener instead of a click listener which isn't triggered by the spacebarhttps://stackoverflow.com/questions/27878940/spacebar-triggering-click-event-on-checkbox
test plan