Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-a11y-utils): fix popover reopen when clicking the trigger #1348

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

balzss
Copy link
Contributor

@balzss balzss commented Nov 3, 2023

INSTUI-3925

test plan:

  • go to the Popover components page
  • go to the "Controllerd Popover" section
  • click on the "Sign in" button to open the popover
  • click on it again -> the popover should close

@balzss balzss requested review from matyasf and joyenjoyer November 3, 2023 13:00
@balzss balzss self-assigned this Nov 3, 2023
@balzss balzss force-pushed the fix/popover-reopens branch from 1f2aa2f to 8ce4717 Compare November 3, 2023 14:05
Copy link

github-actions bot commented Nov 3, 2023

Preview URL: https://1348--preview-instui.netlify.app

Copy link
Contributor

@joyenjoyer joyenjoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@balzss balzss requested a review from HerrTopi November 3, 2023 15:28
@balzss balzss merged commit 895cdfc into master Nov 3, 2023
4 checks passed
@balzss balzss deleted the fix/popover-reopens branch November 3, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants