-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: refactor markdown rendering and add switching … #1349
Conversation
0d8deb5
to
016ec21
Compare
Preview URL: https://1349--preview-instui.netlify.app |
e71731b
to
d004323
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I try to open a functional example in CodeSandbox I get and error: {"error":"Unable to process params for /define - please double check them. See https://codesandbox.io/docs/importing#create-wizard for more details."}
Also see my other comments.
const { styles } = this.props | ||
const { code, fullscreen, rtl } = this.state | ||
const PreviewComponent = ({ themeKey, themes }: AppContextType) => ( | ||
renderPreview = (code: any, themeKey: any, themes: any) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please type these?
fullscreen={fullscreen} | ||
rtl={rtl} | ||
themeKey={themeKey} | ||
themes={themes} | ||
/> | ||
</PreviewErrorBoundary> | ||
) | ||
} | ||
|
||
renderTabPanel = (themeKey: any, themes: any) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please type these?
d004323
to
47808b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to display the class/function tab all the time? might be better to only show when users open the source code of the component. otherwise it looks good
add contributor guides, remove design category. Add sorting to the categories
Alert, Appnav, Badge, Button, Calendar, Checkbox, ColorContrast, ColorMixer, ColorPicker, ColorPreset TEST PLAN: Check if examples are rendered correctly and are working as the class based ones
47808b9
to
3843620
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
…feature to examples