Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add storybook example guide to guides #1357

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Conversation

HerrTopi
Copy link
Contributor

@HerrTopi HerrTopi commented Nov 8, 2023

Closes: INSTUI-3931

Copy link

github-actions bot commented Nov 8, 2023

Preview URL: https://1357--preview-instui.netlify.app

Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc is there, but its out of date. If we include it please make these changes:

  • it should be noted in the doc that this is for internal development, not something for end users.
  • run through the doc and check for outdated parts, e.g. npm run generate:sketch does not exists anymore

@HerrTopi HerrTopi force-pushed the movestorybookreadme branch from ebd6a5b to 19e4cd5 Compare February 2, 2024 11:54
@HerrTopi HerrTopi force-pushed the movestorybookreadme branch from 19e4cd5 to 1987fef Compare February 2, 2024 11:55
@HerrTopi HerrTopi requested a review from matyasf February 2, 2024 11:56
@HerrTopi HerrTopi merged commit 4bcd111 into master Feb 2, 2024
6 of 7 checks passed
@HerrTopi HerrTopi deleted the movestorybookreadme branch February 2, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants