Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shared-types,ui-heading): change h1 heading weight #1374

Merged
merged 2 commits into from
Nov 24, 2023
Merged

fix(shared-types,ui-heading): change h1 heading weight #1374

merged 2 commits into from
Nov 24, 2023

Conversation

joyenjoyer
Copy link
Contributor

@joyenjoyer joyenjoyer commented Nov 22, 2023 •
edited
Loading

Closes: INSTUI-3934

Test plan: check if h1 level has font weight of 400

Closes: INSTUI-3937

Test plan: check if scrollbar appears for this codeblock:

<Flex direction="column" alignItems="stretch" textAlign="start">
      <Flex.Item margin="none none x-small">
        <Heading level="h4">Promotion Code(s)</Heading>
      </Flex.Item>
    </Flex>

@joyenjoyer joyenjoyer self-assigned this Nov 22, 2023
@github-actions GitHub Actions
Copy link

Preview URL: https://1374--preview-instui.netlify.app

@joyenjoyer joyenjoyer requested a review from balzss November 23, 2023 09:53
@balzss balzss removed the request for review from matyasf November 23, 2023 09:53
@joyenjoyer joyenjoyer force-pushed the INSTUI-3934_update-h1-fontweight branch from 44522a8 to e9c9ada Compare November 23, 2023 12:14
@balzss balzss self-requested a review November 23, 2023 13:15
@joyenjoyer joyenjoyer merged commit ac8da80 into master Nov 24, 2023
4 checks passed
@joyenjoyer joyenjoyer deleted the INSTUI-3934_update-h1-fontweight branch November 24, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balzss balzss balzss approved these changes

@HerrTopi HerrTopi HerrTopi approved these changes

Assignees

@joyenjoyer joyenjoyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joyenjoyer @HerrTopi @balzss