feat(many): add new Typography tokens and update text and heading #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HerrTopi
force-pushed
the
typo
branch
3 times, most recently
from
e0fcafc to
222ed9f
Compare
HerrTopi
requested review from
matyasf and
balzss
and removed request for
joyenjoyer
matyasf
requested changes
Dec 17, 2024
docs/guides/typography-system.md
Outdated
|
|
||
| ## Legacy values | ||
|
|
||
| For compatibility reasons we still provide the legacy typography tokens (xxLarge, medium, etc.) so updating InstUI is easier but these tokens shouldn't be used when creating new screens. |
There was a problem hiding this comment.
Please list here what is exactly deprecated. Also can we make some conversation table like
lineHeight 'lineHeightCondensed' --> 'lineHeight125'
There was a problem hiding this comment.
There is no official mapping, however, I added the deprecated list
Closes: INSTUI-4403
matyasf
approved these changes
Dec 17, 2024
balzss
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: INSTUI-4403