migtd: add error status for invalid policy #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyao1
reviewed
Jan 2, 2024
src/migtd/src/migration/mod.rs
Outdated
| @@ -137,7 +139,8 @@ pub enum MigrationResult { | |||
| NetworkError = 5, | |||
| SecureSessionError = 6, | |||
| MutualAttestationError = 7, | |||
| MigPolicyError = 8, | |||
| PolicyUnqulifiedError = 8, | |||
There was a problem hiding this comment.
typo: should be PolicyUnqualifiedError
Suggest to use: PolicyUnsatisfiedError
jyao1
reviewed
Jan 2, 2024
src/migtd/src/ratls.rs
Outdated
| @@ -72,7 +73,8 @@ pub const SERVER_AUTH: ObjectIdentifier = ObjectIdentifier::new("1.3.6.1.5.5.7.3 | |||
| pub const CLIENT_AUTH: ObjectIdentifier = ObjectIdentifier::new("1.3.6.1.5.5.7.3.2"); | |||
| pub const ID_EC_SIG_OID: ObjectIdentifier = ObjectIdentifier::new("1.2.840.10045.4.3.3"); | |||
|
|
|||
| pub const MIG_POLICY_ERROR: &str = "MigPolicyError"; | |||
| pub const MIG_POLICY_UNQULIFIED_ERROR: &str = "PolicyUnqualifiedError"; | |||
There was a problem hiding this comment.
typo: should be MIG_POLICY_UNQUALIFIED_ERROR
Suggest to use MIG_POLICY_UNSATISFIED_ERROR
Signed-off-by: Jiaqi Gao <[email protected]>
gaojiaqi7
force-pushed
the
1226/add_invalid_policy_status
branch
from
91b5a10 to
7eabcb9
Compare
|
Changed to |
jyao1
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #114