migtd: mask the xfam and attribute
#202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyao1
reviewed
Apr 10, 2024
src/migtd/src/ratls/server_client.rs
Outdated
| @@ -123,7 +123,7 @@ fn verify_peer_cert( | |||
| cert: &[u8], | |||
| quote_local: &[u8], | |||
| ) -> core::result::Result<(), CryptoError> { | |||
| let verified_report_local = attestation::verify_quote(quote_local) | |||
| let mut verified_report_local = attestation::verify_quote(quote_local) | |||
There was a problem hiding this comment.
please don't change attribute here.
We can have a local mut version in authenticate_policy().
jyao1
reviewed
Apr 10, 2024
src/migtd/src/ratls/server_client.rs
Outdated
| @@ -137,14 +137,14 @@ fn verify_peer_cert( | |||
| parse_extensions(extensions).ok_or(CryptoError::ParseCertificate)?; | |||
|
|
|||
| #[cfg(not(feature = "test_disable_ra_and_accept_all"))] | |||
| if let Ok(verified_report_peer) = attestation::verify_quote(quote_report) { | |||
| if let Ok(mut verified_report_peer) = attestation::verify_quote(quote_report) { | |||
gaojiaqi7
force-pushed
the
0409/mask_attributes_xfam
branch
from
7b06679 to
2b26f8b
Compare
MigTD may have different features on different platforms. Mask the attribute and xfam bits that is not required for migtd. Signed-off-by: Jiaqi Gao <[email protected]>
gaojiaqi7
force-pushed
the
0409/mask_attributes_xfam
branch
from
2b26f8b to
a7473b5
Compare
jyao1
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MigTD may have different features on different platforms. Mask the attribute and xfam bits that is not required for migtd.