fix: Don't disable bindless allocation using an undocumented env var #813
+1
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bindless allocation is a core functionality. Having obscure mechanisms disabling it at runtime leads to unwanted side effects, leading to application issues, for example on applications trying to use SYCL bindless textures, that are supposed to be available unconditionally on DG2 and newer (when texturing is supported). This is what is assumed here: https://github.com/oneapi-src/unified-runtime/blob/dd7d5c6256f7ec90be9753e6e5a24d06a6b36fd6/source/adapters/level_zero/device.cpp#L1095 This reverts commit 81644a4. Signed-off-by: Xavier Hallade <[email protected]>
|
Why do bindless textures are needed in SYSMAN mode? in SYSMAN_NO_CONTEXT_MODE - Wddm context is not created so there is no GPU execution possible. Application setting this mode is not executing any kernels on GPU |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bindless allocation is a core functionality. Having obscure mechanisms disabling it at runtime leads to unwanted side effects, leading to application issues, for example on applications trying to use SYCL bindless textures, that are supposed to be available unconditionally on DG2 and newer (when texturing is supported).
This is what is assumed here:
https://github.com/oneapi-src/unified-runtime/blob/dd7d5c6256f7ec90be9753e6e5a24d06a6b36fd6/source/adapters/level_zero/device.cpp#L1095
This reverts commit 81644a4.