Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gaudi] Improve Gaudi workflow for self-hosted runner #268

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Deegue
Copy link
Contributor

@Deegue Deegue commented Jul 17, 2024

No description provided.

@Deegue
Copy link
Contributor Author

Deegue commented Jul 17, 2024

Gentle ping @carsonwang for review. These changes are for our new self-hosted workflow, which is mainly handled by python instead of shell. So we have to wrap some shell code into python for better interaction.

@carsonwang
Copy link
Contributor

Can you please run the CI tests on the Gaudi node for this PR. Let's make sure the the tests can pass.

@Deegue
Copy link
Contributor Author

Deegue commented Jul 17, 2024

Can you please run the CI tests on the Gaudi node for this PR. Let's make sure the the tests can pass.

I think we should merge #225 first.

@carsonwang
Copy link
Contributor

Can you please run the CI tests on the Gaudi node for this PR. Let's make sure the the tests can pass.

I think we should merge #225 first.

You can add the changes in the PR to that one so tests can run.

@Deegue
Copy link
Contributor Author

Deegue commented Jul 17, 2024

Can you please run the CI tests on the Gaudi node for this PR. Let's make sure the the tests can pass.

I think we should merge #225 first.

You can add the changes in the PR to that one so tests can run.

Can you please run the CI tests on the Gaudi node for this PR. Let's make sure the the tests can pass.

I think we should merge #225 first.

You can add the changes in the PR to that one so tests can run.

That PR passed CI and was validated successfully. I prefer separating two things into different PRs.

@Deegue
Copy link
Contributor Author

Deegue commented Jul 17, 2024

image

The result was posted to #225. It has been proved Gaudi runs successfully under these two PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants