[SYCL] Reduce heap allocations from sycl::local_accessor
#17147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally, there should be zero but we can't fix that without ABI break (both present, and potential future one for unanticipated future changes). Reduce what we can now: - don't allocate memory on host (no host device, APIs accessing memory must be called from inside "command") - Use `std::make_shared` to fold two allocation into one for pImpl idiom
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
| @@ -119,19 +119,12 @@ const sycl::range<3> &LocalAccessorBaseHost::getSize() const { | |||
| return impl->MSize; | |||
| } | |||
| void *LocalAccessorBaseHost::getPtr() { | |||
| // Const cast this in order to call the const getPtr. | |||
| return const_cast<const LocalAccessorBaseHost *>(this)->getPtr(); | |||
| // Must not be called. | |||
There was a problem hiding this comment.
For the sake of debugging, in case this doesn't hold, could we have an assert here that always fails?
There was a problem hiding this comment.
We have error handling in the base classes before/instead "delegating" to here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, there should be zero but we can't fix that without ABI break (both present, and potential future one for unanticipated future changes).
Reduce what we can now:
std::make_sharedto fold two allocation into one for pImpl idiom