[UR] Update UR loader tag to fix libsycl self-build on windows #19851
Conversation
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| @@ -50,7 +50,7 @@ if(NOT LEVEL_ZERO_LIB_NAME AND NOT LEVEL_ZERO_LIBRARY) | |||
| set(UR_LEVEL_ZERO_LOADER_REPO "https://github.com/oneapi-src/level-zero.git") | |||
| # Remember to update the pkg_check_modules minimum version above when updating the | |||
| # clone tag | |||
| set(UR_LEVEL_ZERO_LOADER_TAG 35c037cdf4aa9a2e6df34b6f1ce1bdc86ac5422f) | |||
| set(UR_LEVEL_ZERO_LOADER_TAG 2e212f73c493bfab0e52381b175131a373db0ca5) | |||
There was a problem hiding this comment.
| set(UR_LEVEL_ZERO_LOADER_TAG 2e212f73c493bfab0e52381b175131a373db0ca5) | |
| set(UR_LEVEL_ZERO_LOADER_TAG v1.24.1) |
https://github.com/oneapi-src/level-zero/releases/tag/v1.24.1
There was a problem hiding this comment.
oh, that is not correct, my fix is merged later that 1.24.1 is created. how should I update pkg_check_modules properly then? I set the last version, but it seems to be not the right way
There was a problem hiding this comment.
Hm, we'd need a new tag if we want those to match. @nrspruit ping.
But I don't think this failure: https://github.com/intel/llvm/actions/runs/17152112326/job/48661284629?pr=19851#step:8:112 is related to mismatch between this tag and the pkg config one. It looks like targets changed in level-zero, and we will need to change them as well in UR cmakes.
There was a problem hiding this comment.
There was a problem hiding this comment.
maybe clean build has never been done after? my changes prevent usage of prebuilt l0 adapter version since I request a newer one
Seems likely. 8959a5e#diff-e83af30e7502eb85108ac495d4a4d50775e6b0eba4e27e8b682c797f8b8a168fR67-R74 looking at this, it seems that we no longer install ze_loader target. @sarnex Is this intentional?
old:
install(TARGETS ur_umf LevelZeroLoader LevelZeroLoader-Headers ComputeRuntimeLevelZero-Headers ze_loader level_zero_utils
new:
set(ADAPTER_L0_TARGETS_TO_INSTALL ur_umf LevelZeroLoader LevelZeroLoader-Headers ComputeRuntimeLevelZero-Headers)
There was a problem hiding this comment.
@sarnex Is this intentional?
AFAIK, he's on vacation. @uditagarwal97 , do you know?
No, I'm not aware of this.
There was a problem hiding this comment.
Sorry, back. Yeah it was intentional but probably this was an unintended side-effect, I expected the LevelZeroLoader target to cover it. @KseniyaTikhomirova can you provide me repro steps on the build failure? Thanks
There was a problem hiding this comment.
@sarnex
I used the command line from failed test (only updated paths). I build sycl first and then tried standalone build of UR:
cmake -S unified-runtime -B build -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_BUILD_TYPE=Release -DUR_ENABLE_TRACING=ON -DUR_DEVELOPER_MODE=ON -DUR_BUILD_TESTS=ON -DUR_BUILD_ADAPTER_L0=ON -DUR_STATIC_LOADER=ON -DUR_STATIC_ADAPTER_L0=ON -DUR_DPCXX=/bin/clang++ -DUR_SYCL_LIBRARY_DIR=/lib -DCMAKE_INSTALL_PREFIX=./install
There was a problem hiding this comment.
Thanks, let me see if I can figure out what's going on.
No description provided.