[SYCL] Use numeric_limits instead of NAN And INFINITY macros #19852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the uses of NAN and INFINITY in the SYCL complex headers with std::numeric_limits<float>::quiet_NaN() and std::numeric_limits<float>::infinity() respectively. This avoids issues where the definition of the macros could cause issues with differing constexpr'ness between platforms. Fixes intel#19114. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| z = __SYCL_CMPLX((INFINITY * (__a * __c - __b * __d)), | ||
| (INFINITY * (__a * __d + __b * __c))); | ||
| z = __SYCL_CMPLX( | ||
| (std::numeric_limits<float>::infinity() * (__a * __c - __b * __d)), |
There was a problem hiding this comment.
shouldn't this be std::numeric_limits<double> (instead of float)?
There was a problem hiding this comment.
The only cases I changed the type were the ones with an immediate cast after them. Though I could change it here, I am worried that there could be some unexpected changes in rounding as a result of that.
| z_real = INFINITY * (__a * __c + __b * __d); | ||
| z_imag = INFINITY * (__b * __c - __a * __d); | ||
| z_real = std::numeric_limits<float>::infinity() * (__a * __c + __b * __d); | ||
| z_imag = std::numeric_limits<float>::infinity() * (__b * __c - __a * __d); |
There was a problem hiding this comment.
ibid. double instead float ?
| return r; | ||
| } | ||
| __SYCL_DEVICE_C | ||
| double __complex__ cproj(double __complex__ z) { | ||
| double __complex__ r = z; | ||
| if (__spirv_IsInf(creal(z)) || __spirv_IsInf(cimag(z))) | ||
| r = __SYCL_CMPLX(INFINITY, __spirv_ocl_copysign(0.0, cimag(z))); | ||
| r = __SYCL_CMPLX(std::numeric_limits<float>::infinity(), |
cperkinsintel
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces the uses of NAN and INFINITY in the SYCL complex headers with std::numeric_limits::quiet_NaN() and std::numeric_limits::infinity() respectively. This avoids issues where the definition of the macros could cause issues with differing constexpr'ness between platforms.
Fixes #19114.