[OVEP] Fix UnsupportedOpMode logic for Reshape #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdvoretc-intel
force-pushed
the
reshape_support_check_fix
branch
from
664e75b to
c8cada8
Compare
sfatimar
approved these changes
Jun 12, 2025
|
Please update branch |
Assumptions about number of inputs to Reshape nodes were causing crashes. The check has been adjusted to be functional with Reshape only having one input.
mdvoretc-intel
force-pushed
the
reshape_support_check_fix
branch
from
c8cada8 to
a3e1c1c
Compare
Kotomi-Du
reviewed
Jun 12, 2025
| @@ -419,7 +419,8 @@ void DataOps::populate_op_mode_supported() { | |||
| UnsupportedOpMode obj = {{V_2023_1, V_2023_2, V_2023_3, V_2024_0, V_2024_1, V_2024_2, | |||
| V_2024_3, V_2024_4, V_2024_5, V_2024_6, V_2025_0, V_2025_1}, | |||
| [this](const Node* node, const InitializedTensorSet&) { | |||
| const auto& input_arg = node->InputDefs()[1]; | |||
| const auto& input_args = node->InputDefs(); | |||
| const auto& input_arg = (input_args.size() > 1) ? input_args[1] : input_args[0]; | |||
There was a problem hiding this comment.
May I ask how do we know the index 0 or 1 in the input_args is the parameter we want?
There was a problem hiding this comment.
The original code assumes that the two provided parameters are the tensor containing the target shape and the data to be reordered. This change addresses the cases where the shape information is embedded as a metaparameter.
There was a problem hiding this comment.
Then is it better to figure out why some cases put the shape information invisible or some not? So we can make it consistent for all cases. Just a brainstorming here, not a requirement for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assumptions about number of inputs to Reshape nodes were causing crashes. The check has been adjusted to be functional with Reshape only having one input.