Pin 2024 03 27 #15
Merged
Pin 2024 03 27 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rch#6268) This commit reenables test/test_zero1.py for GPU. It is passing with latest torch/xla (commit e1c94df). pytorch#6260
This is useful for scoping up the single graph, and seeing how compiler is able to optimise it. This is is optional i.e not added by default. Once we start setting up another benchmark suite with profiling info etc. this should be run additionally, but separately so CUPTI interface won't interact with pure CUDA events. We do not measure compilation time for this option yet.
With the pure wall time infrastructure came nice ability to do microbenchmarks easily. I added the sample microbenchmark for matmul.
This reverts commit 0c81365. It causes OOMs for some training workloads on GPUs, and slows down others.
This PR introduces, and integrates a verification module under the --verify flag. The verification module gets model output as an input, model/benchmark reconstruction args, then runs the eager and finally calculates the relative error and compares it against the provided threshold to return the appropriate error code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin 2024 03 27
TORCHXLA_PIN_COMMIT=27ae6dc955734b223e2b93e1c5bbcd681b0537fd