-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactors-&-fixes #201
Merged
Merged
refactors-&-fixes #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the command data structure to replace `totalArgs` with `requiredArgs` for better clarity. Adjusts related logic in the `BasePrefixCommand` class to reflect this change. Modifies the button style in the About command and enhances the description formatting for improved readability and organization.
Integrate TempHubService into BaseClient to manage chat groups. Define ChatGroup and ServerConnection for better type safety. Implement TempHubManager for Redis-based storage and retrieval of chat groups and channel preferences. These changes enhance the application's ability to handle chat group dynamics and user preferences efficiently.
Refactor the message handling in the `messageCreate` event by introducing `MessageProcessor` and `ConnectionService` for better separation of concerns. Add a new `CompactMessageFormatter` to handle message formatting in a compact mode, improving the flexibility maintainability of the code. This change enhances the overall architecture and prepares the codebase for future features related to message processing and formatting.
Sets the user's activity to display the current version and shard information. Refactors the unblacklist check to simplify the logic and ensure it only updates when necessary. This enhances user experience and optimizes the event handling process.
Introduce the `buildAppealSubmitButton` function in `BlacklistAppeal.ts` to create a button for users to appeal their blacklist status. Remove the duplicate button implementation from `blacklistUtils.ts` to maintain code clarity and avoid redundancy. This change enhances user interaction by providing a clear method for appealing blacklist decisions.
…and update Add checks to ensure connections before deletion and update operations in `deleteConnection` and `update`. This pre errors when attempting to on non-existent . Update the `guildDelete event handler to handlepotential null values gracefully logging guild leaves.
Defer interaction replies when necessary in HubJoinService to ensure ephemeral responses are properly managed. Update RulesScreening to a dynamic reply method sending responses, enhancing consistency and maintainability across interaction handling.
Imports the `RedisKeys` from the constants file to ensure proper functionality. Removes the outdated comment regarding errors in updating records, as it no longer reflects the current state of the code.
Updates several dependencies to their latest versions, including `@types/node`, `@typescript-eslint/parser`, `@typescript-eslint/types`, `@typescript-eslint/typescript-estree`, and `prisma`. This ensures compatibility with the latest features and fixes, improving overall stability and performance of the project. Additionally, it updates the `@types/qs` package to version 6.9.17 for enhanced type definitions.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.