Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy workflows, translation strings, and remove unsused images #10504

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

hornc
Copy link
Collaborator

@hornc hornc commented Feb 25, 2025

This PR:

  • Prevents internetarchive project only github workflows (slack bot integrations and github issue monitoring) from running on forks
  • Removes an unused support template and corresponding i18n strings: openlibrary/templates/support.html
  • Removes footer link to inactive social-media
  • Deletes some unused / duplicated static/images

Technical

Testing

Screenshot

Stakeholders

@hornc hornc marked this pull request as ready for review February 25, 2025 20:52
@hornc hornc changed the title Tidy workflows and translation strings Tidy workflows, translation strings, and remove unsused images Feb 25, 2025
@hornc hornc added the Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed] label Feb 25, 2025
@hornc hornc requested a review from mekarpeles February 27, 2025 02:14
Copy link
Member

@mekarpeles mekarpeles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tweet.svg used on footer

@mekarpeles mekarpeles self-assigned this Feb 28, 2025
@hornc
Copy link
Collaborator Author

hornc commented Mar 1, 2025

@mekarpeles This PR removes that from the footer too. The most recent posts there are 5 years or older, it doesn't appear an active relevant way to contact or interact with OL.

@hornc hornc requested a review from mekarpeles March 2, 2025 00:50
@mekarpeles
Copy link
Member

mekarpeles commented Mar 6, 2025

@horn, our last post was mid January
https://x.com/openlibrary/status/1880031345189302753

@mekarpeles
Copy link
Member

mekarpeles commented Mar 6, 2025

This would be a lot easier to review if these were submitted as individual things:

  1. a workflows PR I am happy to review and these changes are useful!
  2. rm unused support template + strings, also very useful PR
  3. rm duplicate images also a useful PR (I'm not sure why the christianity.svg category svg was removed -- it's used on the homepage, though it can certainly be renamed).
  4. there was a previous conversation around the footer where we decided to keep the existing social Update Twitter icon in the footer to the X icon #9676, Change Twitter logo to X on the home page.  #9572, Change Twitter logo to X on the home page. #9573

1 and 2 I'm happy to merge if we open PRs for them and it seems like 3 is mostly there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants