Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On search results, show preview beneath cover #10553

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mekarpeles
Copy link
Member

@mekarpeles mekarpeles commented Mar 8, 2025

Closes #10199 #10366

This modifies the Preview button so that each previewable book on the search results page has a preview link, styled like on the book page.

Instructions

Squash

Testing

Please note that the css was changed between commit 1 and 2 in order to fix specificity but may now need to be quickly re-tested to ensure it's still doing the right thing.

Screenshot

Screenshot 2025-03-08 at 9 54 36 AM

image

Stakeholders

Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is now, the data attribute for analytics is mangled when analytics_attr is None. Have provided a suggestion that may fix this.

Co-authored-by: jimchamp <[email protected]>
@jimchamp jimchamp added the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Preview" link beneath bookcover on Search Result Cards
2 participants