Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nonworking prototype of trusted book provider interstitial #10571

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

nonworking prototype of trusted book provider interstitial #10571

wants to merge 2 commits into from
+32 −0

Conversation

mekarpeles
Copy link
Member

Almost Closes #10561

Technical

Testing

Screenshot

Stakeholders

accesslint[bot]
accesslint bot reviewed Mar 11, 2025
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

openlibrary/templates/interstitial.html
@@ -0,0 +1,28 @@
$def with(url, provider="", wait=5)

<h1></h1>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Headings shouldn't be empty.

@mekarpeles mekarpeles mentioned this pull request Mar 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@accesslint accesslint[bot] accesslint[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Multiple toast messages in Cached Carousels
1 participant
@mekarpeles