Fix python definition for input.slider, require min/max and fix types

interval · Jul 13, 2023 · 61678d7 · 61678d7
1 parent 77fef3b
commit 61678d7
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 13 deletions.
diff --git a/src/demos/basic.py b/src/demos/basic.py
@@ -171,6 +171,21 @@ async def hello_interval():
     return {"hello": "from python!"}
 
 
+@interval.action
+async def default_slider(io: IO):
+    nint = await io.input.slider("Ints", min=0, max=10)
+    nfloat = await io.input.slider("Floats", min=0.0, max=1.0, step=0.1)
+    ndefault = await io.input.slider("Default", min=0, max=10, default_value=2.0)
+
+    print(nint, nfloat, ndefault)
+
+    return {
+        "nint": nint,
+        "nfloat": nfloat,
+        "ndefault": ndefault,
+    }
+
+
 async def manual_action_handler(io: IO):
     await io.display.markdown("IO works!")
 

diff --git a/src/interval_sdk/classes/io.py b/src/interval_sdk/classes/io.py
@@ -284,11 +284,11 @@ def slider(
             self,
             label: str,
             *,
-            min: Optional[Union[float, int]] = None,
-            max: Optional[Union[float, int]] = None,
+            min: int,
+            max: int,
             step: Optional[int] = None,
             help_text: Optional[str] = None,
-            default_value: Optional[Union[float, int]] = None,
+            default_value: Optional[int] = None,
             disabled: Optional[bool] = None,
         ) -> InputIOPromise[Literal["INPUT_SLIDER"], int]:
             ...
@@ -298,21 +298,21 @@ def slider(
             self,
             label: str,
             *,
-            min: Optional[Union[float, int]] = None,
-            max: Optional[Union[float, int]] = None,
-            step: Optional[float] = None,
+            min: Union[int, float],
+            max: Union[int, float],
+            step: Optional[Union[int, float]] = None,
             help_text: Optional[str] = None,
-            default_value: Optional[Union[float, int]] = None,
+            default_value: Optional[Union[int, float]] = None,
             disabled: Optional[bool] = None,
-        ) -> InputIOPromise[Literal["INPUT_SLIDER"], int]:
+        ) -> InputIOPromise[Literal["INPUT_SLIDER"], float]:
             ...
 
         def slider(
             self,
             label: str,
             *,
-            min: Optional[Union[float, int]] = None,
-            max: Optional[Union[float, int]] = None,
+            min: Union[float, int],
+            max: Union[float, int],
             step: Optional[Union[float, int]] = None,
             help_text: Optional[str] = None,
             default_value: Optional[Union[float, int]] = None,
@@ -333,7 +333,12 @@ def slider(
             )
 
             def get_value(val: float):
-                if step is None or isinstance(step, int):
+                if (
+                    isinstance(min, int)
+                    and isinstance(max, int)
+                    and (step is None or isinstance(step, int))
+                    and (default_value is None or isinstance(default_value, int))
+                ):
                     return int(val)
 
                 return val

diff --git a/src/interval_sdk/io_schema.py b/src/interval_sdk/io_schema.py
@@ -532,8 +532,8 @@ class InputNumberProps(BaseModel):
 
 
 class InputSliderProps(BaseModel):
-    min: Optional[Union[float, int]]
-    max: Optional[Union[float, int]]
+    min: Union[float, int]
+    max: Union[float, int]
     step: Optional[Union[float, int]]
     help_text: Optional[str]
     default_value: Optional[Union[float, int]]