Support modding dual UWP/XInput applications #41
Conversation
If a process can use either the XInput or UWP mod, enter it into the process list twice, once for each mod kind, instead of only listing the UWP mod as an option.
|
Example resulting process list: I don't know exactly why, but modded Celeste specifically shows up as UWP whereas base Celeste is XInput. Only injecting the XInput mod actually functions to capture the rumble commands. |
|
It's that our process finding code is really dumb, and modded Celeste probably has something injected that brings in UWP somewhere, even though the main game doesn't bind to it. What we should do is have our injected code handle both XInput and UWP hooking at the same time, mainly because I'm also going to yank our process enumeration w/ library info since that's what triggers antivirus software. That said, I've been saying I've been going to do that for years and here we are, so I'll take this for now at least. |
Does that mean this PR is good to merge (once you find the time to do so)? I've fixed the silly issues and the PR as it stands is what I used to take the example screenshot. |
If a process can use either the XInput or UWP mod, enter it into the process list twice, once for each mod kind, instead of only listing the UWP mod as an option.