Submit risk scenario update form after creating applied control

[nas-tabchiche]

Summary by CodeRabbit

• New Features

  • Enhanced form submissions now validate data before processing, ensuring only correct inputs trigger actions.
  • Improved risk control creation returns additional details for a more comprehensive feedback experience.
  • Updated form handling on risk scenario edit pages enables dynamic updates for a smoother and more responsive user interface.
  • New form handling mechanism implemented with superForm for improved submission logic and user experience.

• Bug Fixes

  • Ensured consistent initialization of cached values in form components to prevent potential issues.

[coderabbitai]

Walkthrough

The changes update form handling and control flows across three files. In the model form component, the synchronous click handler is replaced with an asynchronous one that validates form data before confirming the action while retaining cache deletion. In the risk-scenarios server code, the action now returns additional new control details along with the form state. The corresponding page component has been refactored to integrate a SuperForm mechanism for improved form submission and reactive data updates.

Changes

Files	Change Summary
frontend/src/lib/components/Forms/ModelForm.svelte	Replaced the synchronous click handler with an asynchronous version that first validates the form (using form.validateForm(data)) before calling parent.onConfirm(event), while ensuring createModalCache.deleteCache(model.urlModel) is always executed.
frontend/src/routes/…/risk-scenarios/[id=uuid]/edit/+page.server.ts frontend/src/routes/…/risk-scenarios/[id=uuid]/edit/+page.svelte	Updated the createAppliedControl action to return both the form and a new control object. The edit page now integrates superForm for enhanced form handling, introducing reactive state updates and updated component property bindings.
frontend/src/lib/components/Forms/TextField.svelte	Initialized cachedValue with undefined to ensure consistent initialization in TypeScript.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant MF as ModelForm.svelte
    participant F as Form Validator
    participant P as Parent Component
    participant C as Cache Manager

    U->>MF: Click Save Button
    MF->>F: Call validateForm(data)
    alt If valid
        F-->>MF: Return valid result
        MF->>P: Call onConfirm(event)
    else If invalid
        F-->>MF: Return invalid result
    end
    MF->>C: Call deleteCache(model.urlModel)

Loading

sequenceDiagram
    participant U as User
    participant PF as +page.svelte (SuperForm)
    participant PS as +page.server.ts
    participant M as Modal

    U->>PF: Interact with form
    PF->>PS: Submit createAppliedControl action
    PS-->>PF: Return { form, newControl }
    alt New control exists
        PF->>PF: Update reactive form store
    end
    M->>PF: Success response triggers _form.submit()

Loading

Possibly related PRs

• fix: proper association of newly created foreign object inside an update view #1390: Addresses similar changes in form handling and return structure enhancements, particularly in the button click event handler modifications.

Suggested reviewers

• ab-smith

Poem

I'm a coding rabbit, hopping all around,
Validating forms so no bugs are found.
With async jumps and cache cleared trails,
SuperForm magic never fails.
I nibble through code, light and free—
Celebrating changes with a happy, twitchy glee! 🐇

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 91994f3 and 9246cd2.

📒 Files selected for processing (2)

• frontend/src/lib/components/Forms/TextField.svelte (1 hunks)
• frontend/src/routes/(app)/(internal)/risk-scenarios/[id=uuid]/edit/+page.svelte (21 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: enterprise-startup-docker-compose-test
• GitHub Check: enterprise-functional-tests (3.12, chromium)
• GitHub Check: startup-functional-test (3.12)
• GitHub Check: functional-tests (3.12, chromium)
• GitHub Check: startup-docker-compose-test
• GitHub Check: enterprise-startup-functional-test (3.12)

🔇 Additional comments (4)

frontend/src/lib/components/Forms/TextField.svelte (1)

14-14: LGTM! Explicit initialization improves type safety.

The explicit initialization of cachedValue to undefined aligns with TypeScript best practices and ensures consistent behavior.

frontend/src/routes/(app)/(internal)/risk-scenarios/[id=uuid]/edit/+page.svelte (3)

55-63: LGTM! Well-configured SuperForm setup.

The SuperForm configuration includes all necessary options for proper form handling:

• Validation method set to 'auto' for immediate feedback
• JSON data type for proper serialization
• Form state management with invalidation and action application

---

79-84: LGTM! Modal response handler ensures form consistency.

The modal response handler properly submits the form after creating a new control, maintaining data consistency.

---

89-93: Verify the reactive form update logic.

The reactive statement updates the form store when a new control is added. Please ensure that:

1. The field exists in the form before pushing the new control
2. The array is properly initialized before the push operation

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Search for field initialization patterns
ast-grep --pattern 'const _form = superForm($_) {
  $$$
  field: $_[]
  $$$
}'

Length of output: 80

---

🏁 Script executed:

#!/bin/bash
# Get the context for the initialization of _form and formStore from the Svelte file
sed -n '1,150p' frontend/src/routes/(app)/(internal)/risk-scenarios/[id=uuid]/edit/+page.svelte

Length of output: 278

---

🏁 Script executed:

#!/bin/bash
# Using proper quoting to account for special characters in the file path
sed -n '1,150p' "frontend/src/routes/(app)/(internal)/risk-scenarios/[id=uuid]/edit/+page.svelte"

Length of output: 4646

---

🏁 Script executed:

#!/bin/bash
# Retrieve lines 80 to 120 from the file to inspect additional context around the reactive statement.
sed -n '80,120p' "frontend/src/routes/(app)/(internal)/risk-scenarios/[id=uuid]/edit/+page.svelte"

Length of output: 1130

---

Reactive Form Update Logic Verified

• The reactive statement uses optional chaining ($formStore[form?.newControl?.field]?.push(...)) to ensure that the push is only attempted if the specified field exists.
• It assumes that the field’s value in the form store is already initialized as an array—a reasonable expectation given that the store is provided by the SuperForm, which typically sets up the initial form structure.
• If the field is missing or not initialized, the optional chaining will silently avoid calling .push, preventing runtime errors.

Based on the available code, the reactive logic correctly checks for the field’s existence and safely performs the push operation, assuming that the form structure is correctly set up by SuperForm.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Mohamed-Hacene]

0k