fix: fall back on empty string when computing select option labels

[nas-tabchiche]

This fixes a chain of client-side errors on the applied controls form.
The error did not affect the good functioning of the form, but was
unclean.

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of missing data values, ensuring consistent and robust behavior to prevent potential runtime issues.

[coderabbitai]

Walkthrough

The changes primarily update the getOptions function in the CRUD utility by replacing direct property access with the nullish coalescing operator (??). This ensures that both the label property lookup and the append function’s return value default to an empty string when they resolve to undefined. The overall structure of the function and existing comments have been retained.

Changes

File	Summary
frontend/.../crud.ts	Updated getOptions to use the nullish coalescing operator for safe property access and default return values; retained existing comments.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant getOptions
    participant append

    Client->>+getOptions: Call getOptions(input)
    getOptions->>+append: Process input via append()
    append-->>-getOptions: Return value (or undefined)
    getOptions-->>-Client: Return default '' if result is undefined

Loading

Suggested reviewers

• Mohamed-Hacene
• ab-smith

Poem

I'm a rabbit, hopping quick and light,
Making code robust with all my might.
Undefined bugs, now kept away,
Thanks to ?? that saves the day.
With each safe default, my heart feels bright!
🐇💻✨

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

frontend/src/lib/utils/crud.ts (1)

59-62: LGTM! Consider adding type annotations for better type safety.

The use of nullish coalescing operator is a good solution for handling undefined values and preventing client-side errors.

Consider adding type annotations to make the code more type-safe:

-const append = (x, y) => (!y ? x : !x || x == '' ? y : x + ' - ' + y);
+const append = (x: string, y: string): string => (!y ? x : !x || x == '' ? y : x + ' - ' + y);

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e70b116 and ff406b9.

📒 Files selected for processing (1)

• frontend/src/lib/utils/crud.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: startup-functional-test (3.12)
• GitHub Check: startup-docker-compose-test
• GitHub Check: enterprise-startup-functional-test (3.12)
• GitHub Check: functional-tests (3.12, chromium)
• GitHub Check: enterprise-startup-docker-compose-test
• GitHub Check: migrations-check (3.12)
• GitHub Check: enterprise-functional-tests (3.12, chromium)
• GitHub Check: Analyze (python)
• GitHub Check: Analyze (javascript-typescript)

[Mohamed-Hacene]

0k