-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): set all services / activities to exported=false #1132
base: main
Are you sure you want to change the base?
Conversation
All of our services and receivers either receive system broadcasts or Intents / PendingIntents from ourselves (internal use, in other words) so they do not need to be exported
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1132 +/- ##
=======================================
Coverage 77.08% 77.08%
=======================================
Files 32 32
Lines 1727 1727
Branches 578 579 +1
=======================================
Hits 1331 1331
Misses 343 343
Partials 53 53 |
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
just waiting for testing, this one should be fine |
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
Still need to review PR stack, didn't beat the stale bot... |
All of our services and receivers either receive system broadcasts or Intents / PendingIntents from ourselves (internal use, in other words) so they do not need to be exported