Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the subscribe start mode #1093

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Remove the subscribe start mode #1093

merged 2 commits into from
Feb 12, 2024

Conversation

AlCalzone
Copy link
Collaborator

@AlCalzone AlCalzone commented Feb 12, 2024

PR Checklist:

  • Provide a meaningful description to this PR or mention which issues this fixes.
  • Ensure the project builds with npm run build
  • Add tests for your change. This includes negative tests (i.e. inputs that need to fail) as well as baseline tests (i.e. how should the directory structure look like?).
  • Run the test suite with npm test
  • If there are baseline changes, review them and make a separate commit for them with the comment "accept baselines" if they are desired changes - no changes
  • If you added a required option, also add it to the template creation (.github/create_templates.ts)
  • Add a detailed migration description to docs/updates explaining what the user needs to do when manually updating an existing project
  • Add your changes to CHANGELOG.md (referencing the migration description and this PR or the issue you fixed)

Description:
As discussed behind the scenes, this start mode doesn't really make sense nowadays, isn't documented anywhere and probably not even supported correctly.

fixes: #1088

@AlCalzone AlCalzone merged commit 699e1e0 into master Feb 12, 2024
6 checks passed
@AlCalzone AlCalzone deleted the remove-legacy-start-modes branch February 12, 2024 12:41
AlCalzone added a commit that referenced this pull request Feb 12, 2024
* (theknut) Make ioBroker types available in the test directory (#1091)
* (theknut) Add `licenseInformation` field to `io-package.json` (#1092)
* (AlCalzone) Remove the `subscribe` start mode (#1093)
* (AlCalzone)  Remove the legacy way of creating adapters without classes (#1094)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] add warning for unusual modes or remove them completly
1 participant