Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove icon from adminTab for Admin 5 #754

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

AlCalzone
Copy link
Collaborator

PR Checklist:

  • Provide a meaningful description to this PR or mention which issues this fixes.
  • Add tests for your change. This includes negative tests (i.e. inputs that need to fail) as well as baseline tests (i.e. how should the directory structure look like?).
  • Run the test suite with npm test
  • If there are baseline changes, review them and make a separate commit for them with the comment "accept baselines" if they are desired changes
  • Ensure the project builds with npm run build
  • If you added a required option, also add it to the template creation (.github/create_templates.ts)
  • Add a detailed migration description to docs/updates explaining what the user needs to do when manually updating an existing project
  • Add your changes to CHANGELOG.md (referencing the migration description and this PR or the issue you fixed)

Description:
fixes: #741

currently blocked by the schema which still requires the attribute

@AlCalzone AlCalzone marked this pull request as draft May 15, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After Admin 5: adjust admin tab to no longer contain an icon
1 participant