Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(test): add locale best practice #28699

Merged
merged 1 commit into from
Dec 13, 2023
Merged

docs(test): add locale best practice #28699

merged 1 commit into from
Dec 13, 2023

Conversation

liamdebeasi
Copy link
Contributor

This best practice currently resides in our internal testing process docs. I think this is valuable information for contributors to have as well, so I've added it to our public best practices doc.

This best practice currently resides in our internal testing process docs. I think this is valuable information for contributors to have as well, so I've added it to our public best practices doc.
@github-actions github-actions bot added the package: core @ionic/core package label Dec 13, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review December 13, 2023 18:27
@liamdebeasi liamdebeasi requested a review from a team as a code owner December 13, 2023 18:27
@liamdebeasi liamdebeasi requested review from brandyscarney and removed request for a team December 13, 2023 18:27
@liamdebeasi liamdebeasi added this pull request to the merge queue Dec 13, 2023
Merged via the queue into main with commit ae6c353 Dec 13, 2023
46 checks passed
@liamdebeasi liamdebeasi deleted the liamdebeasi-patch-4 branch December 13, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants