Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): checkout files when updating package-lock #28778

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jan 3, 2024

In #28697 I moved the package-lock work to its own step to lets us re-run that if it fails. However, I forgot to checkout the project files in that step, so there was no package-lock.json file to update resulting in an error.

@liamdebeasi liamdebeasi marked this pull request as ready for review January 3, 2024 16:44
@liamdebeasi liamdebeasi requested a review from a team as a code owner January 3, 2024 16:44
@liamdebeasi liamdebeasi requested review from averyjohnston and removed request for a team January 3, 2024 16:44
@liamdebeasi liamdebeasi marked this pull request as draft January 3, 2024 16:44
@liamdebeasi liamdebeasi marked this pull request as ready for review January 3, 2024 16:45
@liamdebeasi liamdebeasi changed the title chore(ci): use local version of lerna chore(ci): checkout files when updating package-lock Jan 3, 2024
@liamdebeasi liamdebeasi added this pull request to the merge queue Jan 9, 2024
Merged via the queue into main with commit 28752ac Jan 9, 2024
46 checks passed
@liamdebeasi liamdebeasi deleted the lerna-local branch January 9, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants