Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme): fix rtl mixin for ionic theme #29977

Merged
merged 2 commits into from
Oct 30, 2024
Merged

fix(theme): fix rtl mixin for ionic theme #29977

merged 2 commits into from
Oct 30, 2024

Conversation

tanner-reits
Copy link
Member

@tanner-reits tanner-reits commented Oct 29, 2024 •
edited by brandyscarney
Loading

Issue number: resolves internal

What is the current behavior?

Unable to use the rtl mixin from the ionic theme global import:

@use "../../themes/ionic/ionic.globals.scss" as globals;

:host {
  @include globals.rtl() {
    ...
  }
}

What is the new behavior?

Allows the rtl mixin to be accessed from the global sass import

Does this introduce a breaking change?

  • Yes
  • No

Other information

@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 4:06pm

@github-actions github-actions bot added the package: core @ionic/core package label Oct 29, 2024
@tanner-reits tanner-reits changed the title misc(theme): fix rtl mixin for ionic theme fix(theme): fix rtl mixin for ionic theme Oct 29, 2024
@tanner-reits tanner-reits marked this pull request as ready for review October 29, 2024 20:22
@tanner-reits tanner-reits requested a review from a team as a code owner October 29, 2024 20:22
brandyscarney
brandyscarney approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

thetaPC
thetaPC approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tanner-reits tanner-reits merged commit 4ddc053 into next Oct 30, 2024
46 checks passed
@tanner-reits tanner-reits deleted the tr/ROU-11204 branch October 30, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetaPC thetaPC thetaPC approved these changes

@brandyscarney brandyscarney brandyscarney approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanner-reits @brandyscarney @thetaPC