refactor(many): remove *.ionic.vars files #29983
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
changed the title
| $tabbar-ionic-background: var(--ion-tab-bar-background, globals.$ion-primitives-base-white); | ||
| $tabbar-ionic-background-activated: var(--ion-tab-bar-background-activated, globals.$ion-primitives-neutral-100); | ||
| $tabbar-ionic-background-focused: var(--ion-tab-bar-background-focused, transparent); | ||
| $tabbar-ionic-color: var(--ion-tab-bar-color, globals.$ion-primitives-neutral-800); | ||
| $tabbar-ionic-color-selected: var(--ion-tab-bar-color-selected, globals.$ion-semantics-primary-base); | ||
| $tabbar-ionic-border-color: var(--ion-tab-bar-border-color, transparent); |
There was a problem hiding this comment.
Why are we creating special variables for these instead of just referencing the existing variables like we do for everything else?
There was a problem hiding this comment.
These are created separately because they use the global application color variables defined here: https://ionicframework.com/docs/theming/themes#application-colors
This matches how ios and md define them:
ionic-framework/core/src/themes/native/native.theme.default.md.scss
Lines 15 to 22 in ca091e2
Ideally we would want to add more of these to the ionic theme to match the available colors offered for toolbar, item, etc.
There was a problem hiding this comment.
Gotcha. Thanks for clarifying!
Issue number: internal
What is the current behavior?
Some components have
component.ionic.vars.scssfiles defined for the Ionic theme.What is the new behavior?
*.ionic.vars.scssfiles for item, list and input and uses the design tokens directlytab-bar.ionic.vars.scssfile and moves the variables to the default ionic theme file since this uses global css variablesDoes this introduce a breaking change?