fix(overlays): focus management with checkbox/radio #30026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
Using
TaborShift + Tabto focus through elements in a modal won't behave as expected when usingion-checkboxorion-radiowithin anion-item. Previously, the behavior would result in the last item in a list getting focus styling, butdocument.activeElementwould still be the first actionable item in the overlayWhat is the new behavior?
For checkboxes, the
ion-checkboxelement itself will be focused rather than the encapsulatingion-itemFor radios, the
ion-radio-groupwill be used to focus the appropriate element. This will be the firstion-radioif there is no "checked" item, or the "checked" item if one exists.Does this introduce a breaking change?
Other information