Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avatar): remove avatar border on ionic theme #30045

Merged
merged 2 commits into from
Nov 27, 2024
Merged

fix(avatar): remove avatar border on ionic theme #30045

merged 2 commits into from
Nov 27, 2024

Conversation

BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented Nov 27, 2024

Issue number: internal


What is the current behavior?

  • Removed avatar border with ionic theme, to align with UX/UI design.
  • Updated snapshots

Does this introduce a breaking change?

  • Yes
  • No

Other information

Avatar Ionic Sample

@BenOsodrac BenOsodrac added package: core @ionic/core package type: bug a confirmed bug report labels Nov 27, 2024
@BenOsodrac BenOsodrac requested a review from a team as a code owner November 27, 2024 10:44
@BenOsodrac BenOsodrac requested a review from gnbm November 27, 2024 10:44
Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 10:44am

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenOsodrac BenOsodrac merged commit 2f538b3 into next Nov 27, 2024
48 checks passed
@BenOsodrac BenOsodrac deleted the ROU-11414 branch November 27, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants