Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(git): update next from main #30050

Merged
merged 10 commits into from
Nov 27, 2024
Merged

chore(git): update next from main #30050

merged 10 commits into from
Nov 27, 2024

Commits on Nov 8, 2024

  1. test(segment): fix flaky gesture test and re-enable (#30008)

    Issue number: internal
    
    ---------
    
    <!-- Please do not submit updates to dependencies unless it fixes an
    issue. -->
    
    <!-- Please try to limit your pull request to one type (bugfix, feature,
    etc). Submit multiple pull requests if needed. -->
    
    ## What is the current behavior?
    <!-- Please describe the current behavior that you are modifying. -->
    
    There's a flaky test that was disabled for segment. It's been known that
    gesture tests are prone to be flaky.
    
    ## What is the new behavior?
    <!-- Please describe the behavior or changes that are being added by
    this PR. -->
    
    - Fixed the test by switching to the improved `dragElementBy` function
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!--
      If this introduces a breaking change:
    1. Describe the impact and migration path for existing applications
    below.
      2. Update the BREAKING.md file with the breaking change.
    3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
    See
    https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
    for more information.
    -->
    
    
    ## Other information
    
    <!-- Any other information that is important to this PR such as
    screenshots of how the component looks before and after the change. -->
    
    N/A
    thetaPC authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    3216108 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. fix(toast): swipe gesture works with custom container layout (#29999)

    Issue number: resolves #29998
    
    ---------
    
    <!-- Please do not submit updates to dependencies unless it fixes an
    issue. -->
    
    <!-- Please try to limit your pull request to one type (bugfix, feature,
    etc). Submit multiple pull requests if needed. -->
    
    ## What is the current behavior?
    
    Applying a custom layout to `ion-toast::part(container)`, for example
    `width: 50%`, will make the part of the toast outside this element's
    bounds non-interactive for swiping gestures.
    
    
    ## What is the new behavior?
    
    Can swipe from anywhere on the toast with custom layout applied to
    ::part(container)
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [X] No
    
    <!--
      If this introduces a breaking change:
    1. Describe the impact and migration path for existing applications
    below.
      2. Update the BREAKING.md file with the breaking change.
    3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
    See
    https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
    for more information.
    -->
    
    
    ## Other information
    
    | Before | After                                         |
    |-------|-----------------------------------------------------|
    | <video
    src="https://github.com/user-attachments/assets/fc450066-5fb1-4fd9-bfbd-7f2cd55ce855"></video>
    | <video
    src="https://github.com/user-attachments/assets/991f6a42-f6fe-479b-9f68-7e7e35dca799"></video>
    |
    aeharding authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    470decc View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. fix(header): use aria attributes to hide small title when collapsed (#…

    …30027)
    
    Issue number: resolves #29347 
    
    ---------
    
    <!-- Please do not submit updates to dependencies unless it fixes an
    issue. -->
    
    <!-- Please try to limit your pull request to one type (bugfix, feature,
    etc). Submit multiple pull requests if needed. -->
    
    ## What is the current behavior?
    <!-- Please describe the current behavior that you are modifying. -->
    
    Focusable elements like buttons cannot be accessed within the
    `ion-header` when it's collapsed. They're only accessible once the small
    title is displayed.
    
    ## What is the new behavior?
    <!-- Please describe the behavior or changes that are being added by
    this PR. -->
    
    - Moved the `aria-hidden` from the header to `ion-title`, this aligns
    with native.
    - Updated existing test.
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!--
      If this introduces a breaking change:
    1. Describe the impact and migration path for existing applications
    below.
      2. Update the BREAKING.md file with the breaking change.
    3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
    See
    https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
    for more information.
    -->
    
    
    ## Other information
    
    <!-- Any other information that is important to this PR such as
    screenshots of how the component looks before and after the change. -->
    
    Dev build: `8.4.1-dev.11732064156.12837790`
    thetaPC authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    23763ab View commit details
    Browse the repository at this point in the history
  2. fix(overlays): focus management with checkbox/radio (#30026)

    Issue number: resolves internal
    
    ---------
    
    <!-- Please do not submit updates to dependencies unless it fixes an
    issue. -->
    
    <!-- Please try to limit your pull request to one type (bugfix, feature,
    etc). Submit multiple pull requests if needed. -->
    
    ## What is the current behavior?
    <!-- Please describe the current behavior that you are modifying. -->
    
    Using `Tab` or `Shift + Tab` to focus through elements in a modal won't
    behave as expected when using `ion-checkbox` or `ion-radio` within an
    `ion-item`. Previously, the behavior would result in the last item in a
    list getting focus styling, but `document.activeElement` would still be
    the first actionable item in the overlay
    
    ## What is the new behavior?
    <!-- Please describe the behavior or changes that are being added by
    this PR. -->
    
    For checkboxes, the `ion-checkbox` element itself will be focused rather
    than the encapsulating `ion-item`
    
    For radios, the `ion-radio-group` will be used to focus the appropriate
    element. This will be the first `ion-radio` if there is no "checked"
    item, or the "checked" item if one exists.
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!--
      If this introduces a breaking change:
    1. Describe the impact and migration path for existing applications
    below.
      2. Update the BREAKING.md file with the breaking change.
    3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
    See
    https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
    for more information.
    -->
    
    
    ## Other information
    
    <!-- Any other information that is important to this PR such as
    screenshots of how the component looks before and after the change. -->
    tanner-reits authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    8ee42bb View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. fix(overlays): announce info after opening based on platform (#30025)

    Issue number: internal
    
    ---------
    
    <!-- Please do not submit updates to dependencies unless it fixes an
    issue. -->
    
    <!-- Please try to limit your pull request to one type (bugfix, feature,
    etc). Submit multiple pull requests if needed. -->
    
    ## What is the current behavior?
    <!-- Please describe the current behavior that you are modifying. -->
    
    PR #29951 would hide
    the overlays from screen readers while animating. This allows the
    element to navigate to its correct destination for screen readers to
    interact with. Otherwise, the focus rings would never appear. However,
    this ended up breaking the interaction for iOS.
    
    ## What is the new behavior?
    <!-- Please describe the behavior or changes that are being added by
    this PR. -->
    
    - Overlays are hidden from screen readers while animating only if the
    platform is `android`. Since the original issue only applied to Android
    devices.
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!--
      If this introduces a breaking change:
    1. Describe the impact and migration path for existing applications
    below.
      2. Update the BREAKING.md file with the breaking change.
    3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
    See
    https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
    for more information.
    -->
    
    
    ## Other information
    
    <!-- Any other information that is important to this PR such as
    screenshots of how the component looks before and after the change. -->
    
    Dev build: `8.4.1-dev.11732033492.170e160c`
    
    Test on iOS and Android devices.
    thetaPC authored Nov 22, 2024
    Configuration menu
    Copy the full SHA
    f6188c4 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. fix(menu): hide from screen readers while animating (#30036)

    Issue number: internal
    
    ---------
    
    <!-- Please do not submit updates to dependencies unless it fixes an
    issue. -->
    
    <!-- Please try to limit your pull request to one type (bugfix, feature,
    etc). Submit multiple pull requests if needed. -->
    
    ## What is the current behavior?
    <!-- Please describe the current behavior that you are modifying. -->
    
    When the menu is presented on an Android device, TalkBack's focus rings
    may appear in the wrong position due to the transition (specifically
    `transform` styles). This occurs because the focus rings are initially
    displayed at the starting position of the elements before the transition
    begins.
    
    ## What is the new behavior?
    <!-- Please describe the behavior or changes that are being added by
    this PR. -->
    
    - When an overlay is being animated (presenting or dismissing), the
    overlay will hide from screen readers. This allows Talkback to display
    the focus rings on the correct position.
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!--
      If this introduces a breaking change:
    1. Describe the impact and migration path for existing applications
    below.
      2. Update the BREAKING.md file with the breaking change.
    3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
    See
    https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
    for more information.
    -->
    
    
    ## Other information
    
    <!-- Any other information that is important to this PR such as
    screenshots of how the component looks before and after the change. -->
    
    Dev build: `8.4.1-dev.11732305980.19d90e1c`
    
    Related to #29951
    thetaPC authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    845071c View commit details
    Browse the repository at this point in the history
  2. v8.4.1

    Ionitron committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    1c281dc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a90097c View commit details
    Browse the repository at this point in the history
  4. merge release-8.4.1 (#30048)

    v8.4.1
    brandyscarney authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    234d14a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b0a2544 View commit details
    Browse the repository at this point in the history