fix(dist-custom-elements): stop duplicate @stencil/core

[johnjenkins]

What is the current behavior?

Setting the externalRuntime: false on a dist-custom-elements output, whilst at the same time including a 3rd party component / lib that imports from @stencil/core, causes the whole stencil runtime to be included twice:

• once as custom runtime (dictated by flags set via features detected on components at build-time).
• second as the whole runtime (dictated by the 3rd party lib's import)

This duplication in-turn, breaks certain lifecycle events as different internals call different (duplicate) @stencil/core functions.

GitHub Issue Number:

• bug: externalRuntime flag makes @stencil/store changes no trigger render #6040
• bug: Store changes doesn't trigger re-render of a component on dist-custom-elements build #4135

What is the new behavior?

My naive solution is to make sure the same @stencil/core rollup id is included for both 3rd party libs and the direct component imports - the full @stencil/core build - if it's the dist-custom-elements output.

This stops the duplication.

This doesn't have any particularly noticeable impact on bundle size.

Fixes: #6040
Fixes: #4135

Documentation

Does this introduce a breaking change?

• Yes
• No

Testing

• TBD ... not really sure how to

Other information

ATM I have opted for using the same 'custom' stencil core for both src and node_modules but I may have to rethink.

[rjborba]

@johnjenkins thank you so much for working on it.
What is needed to move it from Draft to read to be merged? I may be able to help.

[johnjenkins]

thanks @rjborba - I just wanted to discuss this with Christian before going forward.
This approach might have some implications, so just need to tweak / test a few things. Shouldn't take long

[christian-bromann]

LGTM 👍

[christian-bromann]

@johnjenkins I think we are missing to propagate the lazy variable in some places 🤔