fix(ssr): stop stripping comment nodes #6123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Christian Bromann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
client-hydrate.tsis currently stripping out extra comment nodes ofshadow: truecomponents (this was originally to remove stencil's "internal" comments, which could pollute the component), but in doing so it removes slotted comment nodes which can be used by external tools / libs.After testing, I see stencil's internal comments are removed during other stages of client-side hydration so this extra comment removal is unnecessary (the only time extra comments are seen is during unit tests due to a limitation / difference in how components are rendered on 'server')
GitHub Issue Number: #6120
What is the new behavior?
Fixes #6120
Documentation
Does this introduce a breaking change?
Testing
Other information