Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): multiple component instances sharing initial properties #6126

Merged

Conversation

johnjenkins
Copy link
Contributor

@johnjenkins johnjenkins commented Jan 27, 2025

What is the current behavior?

A regression added (#6084) during hydration, caused the value to be set on / got from the enclosure to the last component instance.

GitHub Issue Number: #6125

What is the new behavior?

Fixes: #6125

The prototype 'get' now uses the current instance ref to get the initial value

Documentation

Does this introduce a breaking change?

  • Yes
  • No

Testing

  • additional e2e test

Other information

@johnjenkins johnjenkins requested a review from a team as a code owner January 27, 2025 21:35
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann merged commit f7ecec3 into ionic-team:main Jan 28, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: multiple of the same custom element - during ssr - will load the last element's property value for all
2 participants