Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): append newChild if parent node doesn't match with patched node #6141

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/runtime/dom-extras.ts
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,21 @@ const patchInsertBefore = (HostElementPrototype: HTMLElement) => {
});
if (found) return newChild;
}

/**
* Fixes an issue where slotted elements are dynamically relocated in React, such as after data fetch.
*
* When a slotted element is passed to another scoped component (e.g., <A><C slot="header"/></A>),
* the child’s __parentNode (original parent node property) does not match this.
*
* To prevent errors, this checks if the current child's parent node differs from this.
* If so, appendChild(newChild) is called to ensure the child is correctly inserted,
* allowing Stencil to properly manage the slot placement.
*/
const parentNode = (currentChild as d.PatchedSlotNode)?.__parentNode;
if (parentNode && !this.isSameNode(parentNode)) {
return this.appendChild(newChild);
}
return (this as d.RenderNode).__insertBefore(newChild, currentChild);
};
};
Expand Down
Loading