Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interfaces #277

Merged
merged 11 commits into from
Nov 17, 2022
Merged

Interfaces #277

merged 11 commits into from
Nov 17, 2022

Commits on Oct 29, 2022

  1. Create module interfaces.py 

      - Add interfaces.py to process responses into third-party library objects
    @vinisalazar
    vinisalazar committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    68d51dd View commit details
    Browse the repository at this point in the history

  2. Use methods from interfaces.py in erddapy.py module

    @vinisalazar
    vinisalazar committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    e60e4e4 View commit details
    Browse the repository at this point in the history

  3. Remove iris typehint

    @vinisalazar
    vinisalazar committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    b6a2086 View commit details
    Browse the repository at this point in the history

  4. Fixing kwargs propagation in interfaces module

    @vinisalazar
    vinisalazar committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    ff2961e View commit details
    Browse the repository at this point in the history

  5. Fix timeout test 

      - Use existing dataset
  - Pass requests_kwargs to 'to_pandas' method
    @vinisalazar
    vinisalazar committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    85f5233 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. Fix interfaces.to_ncCF method 

      - Add protocol check to interfaces function
  - Add self.protocol in ERDDAP.to_ncCF method
    @vinisalazar
    vinisalazar committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    fb95092 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Code review for ioos#277 

      - Don't rename netCDF4 Dataset class
  - Change requests_kwargs default to None
  - Raise exception as object
  - Raise ValueError (instead of return)
  - Get rid of iris exception handling block (in favour of
  pinning latest version)
    @vinisalazar
    vinisalazar committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    90f556f View commit details
    Browse the repository at this point in the history

  2. Use urlopen instead of to_pandas in erddap_request test

    @vinisalazar
    vinisalazar committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    9c363bb View commit details
    Browse the repository at this point in the history

  3. Add offending URL to ValueError

    @vinisalazar
    vinisalazar committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    c097922 View commit details
    Browse the repository at this point in the history

  4. Code review for ioos#277 

      - Initialise dict with curly brackets
  - Improve exception handling in function 'to_pandas'
  - Improve error message in function 'to_ncCF'

Co-authored-by: Filipe <[email protected]>
    @vinisalazar @ocefpaf
    vinisalazar and ocefpaf committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    b4d9d37 View commit details
    Browse the repository at this point in the history

  5. Pin iris version in requirements-dev.txt

    @vinisalazar
    vinisalazar committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    a28f170 View commit details
    Browse the repository at this point in the history