Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard-code the QARTOD variables' standard and long names in the .xml f… #386

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Hard-code the QARTOD variables' standard and long names in the .xml f… #386

merged 4 commits into from
Oct 30, 2024

Conversation

leilabbb
Copy link
Contributor

@leilabbb leilabbb commented Oct 29, 2024 •
edited
Loading

This is related to issue #385 and issue #382

Made a few modifications to hard-code the QARTOD variables' long and standard names:

  • removed the "qartod_monotonic_pressure_flag" [it is no longer part of the QC tests]
  • Changed the required_qartod_vars to a dictionary.
  • Updated the qartod_var_snippets() function to utilize the dictionary and add the attributes long_name and standard_name to the default QARTOD variable attributes if the required QARTOD variable isn't already defined.

@leilabbb leilabbb self-assigned this Oct 29, 2024
@leilabbb
Update build_erddap_catalog.py
ab9b729 
removed white spaces and removed the double " when calling {some_variable} in  tree = etree.fromstring(rf""" 
<dataset> .... </dataset>
            """)
@leilabbb
Update build_erddap_catalog.py
e1b7bb9 
Use double quotes for the  XML dataset datasetID assignment:
datasetID="{deployment.name}"
@benjwadams
Copy link
Contributor

pre-commit.ci autofix

@benjwadams benjwadams merged commit a6c1205 into main Oct 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjwadams benjwadams Awaiting requested review from benjwadams

Assignees

@leilabbb leilabbb

Labels
Bug QC
Projects
None yet
Milestone
FY25Q1- Improved Data QC Processes
Development

Successfully merging this pull request may close these issues.
2 participants
@leilabbb @benjwadams