minor refactor for pubsub #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor refactor for pubsub regarding the message validator and trying to make the code more idiomatic.
mihirn
reviewed
Oct 19, 2023
src/pubsub/momento.rs
Outdated
| error!("pubsub: invalid message received"); | ||
| RESPONSE_EX.increment(); | ||
| PUBSUB_RECEIVE_INVALID.increment(); | ||
| continue; | ||
| } | ||
| MessageValidationResult::Corrupted => { | ||
| Err(ValidationError::Corrupted) => { |
There was a problem hiding this comment.
Curious why one of these cases increments RESPONSE_EX and the other PUBSUB_RECEIVE, but both have a message suggesting they are pubsub messages.
There was a problem hiding this comment.
This might be up for debate. Initially my thought was that invalid messages (perhaps produced by some non-rpc-perf process) should be ignored with just an invalid counter incremented.
mihirn
reviewed
Oct 19, 2023
src/pubsub/kafka.rs
Outdated
| Some(Ok(message)) => match validator.validate(&mut message.to_owned()) { | ||
| Err(ValidationError::Unexpected) => { | ||
| error!("pubsub: invalid message received"); | ||
| RESPONSE_EX.increment(); |
There was a problem hiding this comment.
Is it worth moving the counter stuff into the validation function and having a much simpler match case for both consumers?
There was a problem hiding this comment.
Great idea. Moved into the validator.
mihirn
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor refactor for pubsub regarding the message validator and trying to make the code more idiomatic.