Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add blkalgn support to trace block I/Os and report Granularity and Alignment.
Note: I chose not to create a separate Makefile (for now) as mentioned in the README. This first approach is to gather feedback on the tool and code.
A previous version of the tool using bcc/Python was 'introduced' here:
#4813
Output example:
Help output:
The tool can trace I/Os, filter by device and/or block operation, and generate an output file to JSON with captured information. I think, because of the use of a JSON external library, it requires to have a separate Makefile as stated in the README section. Can you provide feedback on this? Note that it also depends on
math.h
forlog2l
in user space.