-
Notifications
You must be signed in to change notification settings - Fork 7
Remove protobufjs in favor of protons-runtime #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@talentlessguy you might gain more savings switching to protons and protons-runtime instead? It would dudupe with |
Note: I think in general I'd prefer to switch to |
thanks for the suggestion |
FWIW, last time I ran the benchmark suite, protons was just over 20% faster than protobuf-es when serializing/deserializing - https://github.com/ipfs/protons/tree/main/packages/protons-benchmark#usage These kind of performance characteristics are very important to high traffic deployments like Lodestar so it's unlikely to be switched away from elsewhere. |
do you mean protobufjs, and not protons? |
I wonder how hard it would be to replace protobuf-es with protons, will give it a shot rn |
I guess the only thing is that protons compiles protobuf definitions to TypeScript and this is still a js project. |
@achingbrain is the benchmark encode or decode? We're only encode in this repo. |
This closes #31
Switches to protons-runtime
WIP
Progress:
things that are failing
symlinks:
raw files with no content:
there's some missing default value in all of those but i'm not sure where