Skip to content

VXLAN test: Test DUT against reference implementation (FRR) instead of against itself #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jbemmel
Copy link
Collaborator

@jbemmel jbemmel commented May 9, 2025

This allows for the introduction of an OSPF check, clarifying delays a bit. It also guards against a theoretical possibility of devices that only interop with themselves

Proposal in the context of #2254

…f against itself

This allows for the introduction of an OSPF check, clarifying delays a bit
Copy link
Owner

@ipspace ipspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes perfect sense. Will merge once the integration tests I'm running finish.

The once change you should make is to increase the STP timer to 30+ seconds (35 should do the trick). It takes 30 seconds for STP to go from "learning" to "forwarding" and sometimes OSPF starts surprisingly fast.

Also, it would be nice to add the STP time to the wait_times (for example, as stp_forwarding)

@jbemmel jbemmel marked this pull request as draft May 9, 2025 16:33
@jbemmel jbemmel marked this pull request as ready for review May 9, 2025 16:36
@ipspace
Copy link
Owner

ipspace commented May 20, 2025

OK, I'm back ;) and would like to discuss the bigger picture before merging a variant of this (adding @ssasso to the discussion):

A) The same change (one DUT, one or more FRR nodes) should be applied to all VXLAN tests (no worries, I'll do that)
B) That changes the meaning of "VXLAN works" (as in: between identical devices) to "VXLAN works with FRR". I think our FRR VXLAN implementation is solid enough to be a reference implementation (and of course I'll run the full set of integration tests before merging whatever we agree upon).
C) The "multivendor" test becomes obsolete.

Anything else I've missed?

@jbemmel
Copy link
Collaborator Author

jbemmel commented May 20, 2025

B) That changes the meaning of "VXLAN works"

Since the EVPN tests are already structured like this (for the most part), the above is limited to "static VXLAN works" (and shouldn't be a big issue given that the EVPN tests pass)

Some EVPN tests (like 20-vxlan-irb-ospf.yml) could be converted too

@ipspace ipspace added enhancement New feature or request and removed rel_2.0.0-post1 labels May 21, 2025
ipspace added a commit that referenced this pull request May 22, 2025
Also:
* VNI is set to 5000/5001 to deal with ArubaCX FUBAR
* Validation tests check individual components (OSPF, STP...) before
  an end-to-end ping, hopefully resulting in easier troubleshooting
* Test use symbolic wait times for consistency
* Removed unnecessary device from alt-vtep test
* Removed multi-vendor test (all tests are now multi-vendor)
* Remove OSPF-in-VRF from router-on-stick test to work around a
  CL NVUE bug

Replaces #2257
ipspace added a commit that referenced this pull request May 22, 2025
ipspace added a commit that referenced this pull request May 22, 2025
Also:
* VNI is set to 5000/5001 to deal with ArubaCX FUBAR
* Validation tests check individual components (OSPF, STP...) before
  an end-to-end ping, hopefully resulting in easier troubleshooting
* Test use symbolic wait times for consistency
* Removed unnecessary device from alt-vtep test
* Removed multi-vendor test (all tests are now multi-vendor)
* Remove OSPF-in-VRF from router-on-stick test to work around a
  CL NVUE bug
* Use test.fixup plugin to change probe device to EOS when testing
  ArubaCX

Replaces #2257
@jbemmel jbemmel closed this May 22, 2025
@jbemmel jbemmel deleted the vxlan_robust_test branch May 22, 2025 14:32
ipspace added a commit that referenced this pull request May 22, 2025
Also:
* VNI is set to 5000/5001 to deal with ArubaCX FUBAR
* Validation tests check individual components (OSPF, STP...) before
  an end-to-end ping, hopefully resulting in easier troubleshooting
* Test use symbolic wait times for consistency
* Removed unnecessary device from alt-vtep test
* Removed multi-vendor test (all tests are now multi-vendor)
* Remove OSPF-in-VRF from router-on-stick test to work around a
  CL NVUE bug
* Use test.fixup plugin to change probe device to EOS when testing
  ArubaCX

Replaces #2257
ipspace added a commit that referenced this pull request May 22, 2025
Also:
* VNI is set to 5000/5001 to deal with ArubaCX FUBAR
* Validation tests check individual components (OSPF, STP...) before
  an end-to-end ping, hopefully resulting in easier troubleshooting
* Test use symbolic wait times for consistency
* Removed unnecessary device from alt-vtep test
* Removed multi-vendor test (all tests are now multi-vendor)
* Remove OSPF-in-VRF from router-on-stick test to work around a
  CL NVUE bug
* Use test.fixup plugin to change probe device to EOS when testing
  ArubaCX

Replaces #2257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants