-
Notifications
You must be signed in to change notification settings - Fork 80
VXLAN test: Test DUT against reference implementation (FRR) instead of against itself #2257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…f against itself This allows for the introduction of an OSPF check, clarifying delays a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes perfect sense. Will merge once the integration tests I'm running finish.
The once change you should make is to increase the STP timer to 30+ seconds (35 should do the trick). It takes 30 seconds for STP to go from "learning" to "forwarding" and sometimes OSPF starts surprisingly fast.
Also, it would be nice to add the STP time to the wait_times (for example, as stp_forwarding)
OK, I'm back ;) and would like to discuss the bigger picture before merging a variant of this (adding @ssasso to the discussion): A) The same change (one DUT, one or more FRR nodes) should be applied to all VXLAN tests (no worries, I'll do that) Anything else I've missed? |
Since the EVPN tests are already structured like this (for the most part), the above is limited to "static VXLAN works" (and shouldn't be a big issue given that the EVPN tests pass) Some EVPN tests (like 20-vxlan-irb-ospf.yml) could be converted too |
Also: * VNI is set to 5000/5001 to deal with ArubaCX FUBAR * Validation tests check individual components (OSPF, STP...) before an end-to-end ping, hopefully resulting in easier troubleshooting * Test use symbolic wait times for consistency * Removed unnecessary device from alt-vtep test * Removed multi-vendor test (all tests are now multi-vendor) * Remove OSPF-in-VRF from router-on-stick test to work around a CL NVUE bug Replaces #2257
Also: * VNI is set to 5000/5001 to deal with ArubaCX FUBAR * Validation tests check individual components (OSPF, STP...) before an end-to-end ping, hopefully resulting in easier troubleshooting * Test use symbolic wait times for consistency * Removed unnecessary device from alt-vtep test * Removed multi-vendor test (all tests are now multi-vendor) * Remove OSPF-in-VRF from router-on-stick test to work around a CL NVUE bug * Use test.fixup plugin to change probe device to EOS when testing ArubaCX Replaces #2257
Also: * VNI is set to 5000/5001 to deal with ArubaCX FUBAR * Validation tests check individual components (OSPF, STP...) before an end-to-end ping, hopefully resulting in easier troubleshooting * Test use symbolic wait times for consistency * Removed unnecessary device from alt-vtep test * Removed multi-vendor test (all tests are now multi-vendor) * Remove OSPF-in-VRF from router-on-stick test to work around a CL NVUE bug * Use test.fixup plugin to change probe device to EOS when testing ArubaCX Replaces #2257
Also: * VNI is set to 5000/5001 to deal with ArubaCX FUBAR * Validation tests check individual components (OSPF, STP...) before an end-to-end ping, hopefully resulting in easier troubleshooting * Test use symbolic wait times for consistency * Removed unnecessary device from alt-vtep test * Removed multi-vendor test (all tests are now multi-vendor) * Remove OSPF-in-VRF from router-on-stick test to work around a CL NVUE bug * Use test.fixup plugin to change probe device to EOS when testing ArubaCX Replaces #2257
This allows for the introduction of an OSPF check, clarifying delays a bit. It also guards against a theoretical possibility of devices that only interop with themselves
Proposal in the context of #2254